Batch network packets in prepared statements#3402
Merged
Conversation
Deploying node-postgres with
|
| Latest commit: |
e67418f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6417e81.node-postgres.pages.dev |
| Branch Preview URL: | https://bmc-network-packet-perf-fix.node-postgres.pages.dev |
Owner
Author
|
This actually did result in a small speedup on my version of node and osx...though maybe 5-10% (there's so much variance its hard to tell what amount is code change related and what is just "less operating system interrupts got in the way during the run") but there did seem to be a small consistent speedup which is cool! The bigger issue is on some operating system / node combos (wasn't able to identify any myself) there is a much more significant speedup this should offer. |
Owner
Author
|
Special thanks, as always, to @charmander for the tip about |
Owner
Author
|
published in |
jimrandomh
added a commit
to ForumMagnum/ForumMagnum
that referenced
this pull request
Sep 9, 2025
This might have a surprising performance impact due to brianc/node-postgres#3402 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3340
Fixes #3325
Fixes #3098